Update docstrings to address #1205#1531
Conversation
|
As mentioned in plotly/dash-core-components#914 (comment), I think it would be a good idea to escape double quotes in the generated docstrings - even if the added period handles most cases where this would cause problems, the triple-quote potential issue remains. |
|
This looks really good! Such a relief to see all of this fixed. Glad we have test cases here with all of the types. Looks like the double quote issue was fixed, any other concerns here @alexcjohnson ? |
|
Oh, also we need a changelog entry. That and #1531 (comment) then I think this is ready to go! |
|
@harryturr this PR means the rest of the core will need to be included in the next release whether or not there's a changelog entry for each piece, so all the docstrings get rebuilt. |
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Very nice work - big improvement to our docstrings!
|
Thanks for your kind words and assistance with this project! |
This PR updates how the docstrings are generated to address #1205
See more details in dash-docs #1063